Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend bower.json to match bower spec #3212

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Amend bower.json to match bower spec #3212

merged 1 commit into from
Jun 30, 2016

Conversation

kevgathuku
Copy link
Contributor

@kevgathuku kevgathuku commented May 29, 2016 •
edited
Loading

Fixes bower warnings

  • Make the name lowercase
  • Remove font files from the main field as they are referenced in the main CSS file
    From the spec:

Image and font files may be used or referenced within the JS or Sass files, but are not main files as they are not entry-points.

Resolves #3195, #3012, #2389

@kevgathuku
Amend bower.json to match bower spec
e1bc836 
- Make the name lowercase
- Remove font files from the main field as they are referenced in the main CSS file
- Resolves #3195
@kevgathuku kevgathuku mentioned this pull request May 29, 2016
Closed
@kevgathuku
Copy link
Contributor Author

Hi @Dogfalo @acburst do you mind checking this out?

@Dogfalo Dogfalo merged commit 8760264 into Dogfalo:master Jun 30, 2016
@Dogfalo
Copy link
Owner

Dogfalo commented Jun 30, 2016

Thank you

@Dogfalo Dogfalo mentioned this pull request Jun 30, 2016
Closed
@kevgathuku
Copy link
Contributor Author

You're welcome 👍
Thanks for accepting my contribution

@kevgathuku kevgathuku deleted the fix-invalid-bower branch July 1, 2016 04:32
@kevgathuku kevgathuku mentioned this pull request Jan 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevgathuku @Dogfalo