Feature #548 - allow select component to be controlled by keyboard

[robinbortlik]

• refactored dropdown component
• add open and close listeners to dropdown component
• refactored select component (replace span by input)
• add keypress binding and logic to select

[Dogfalo]

I took a look at this, it looks very good. Just wondering why the animation style has been changed for the select dropdown?

[robinbortlik]

Ohh, really? I did not noticed any change in animation. Let me know, if it will need some fixes.

[robinbortlik]

Or do you mean the css style changes? That I had to replace arrow with icon? It is because, it is not possible to use :after selector with input.

[Dogfalo]

Take a look at http://materializecss.com/forms.html and click on the select dropdown. Then if you click the one after the change it has a different effect.

[robinbortlik]

Yes, you are right. I think it is issue with the scrollTo function. hhttps://github.com//pull/582/files#diff-338f03716a63d52eee0f79b4510d617cR245

When you open the select, then the dropdown should be on the position of selected option.
Maybe we can postpone this behaviour with setTimeout. So it will "maybe" stop break the initial animation. I will look on it on tomorrow evening.

[Dogfalo]

Great, looking forward to seeing it. Thanks for taking the time to add this
functionality for us!

On Mon, Feb 2, 2015 at 4:15 PM, Robin Bortlík notifications@github.com
wrote:

Yes, you are right. I think it is issue with the scrollTo function.
hhttps://
github.com//pull/582/files#diff-338f03716a63d52eee0f79b4510d617cR245

When you open the select, then the dropdown should be on the position of
selected option.
Maybe we can postpone this behaviour with setTimeout. So it will "maybe"
stop break the initial animation. I will look on it on tomorrow evening.

—
Reply to this email directly or view it on GitHub
#582 (comment).

Doggy sends his greetings from Mars.

[robinbortlik]

Ok, fixed. Can you test it now? :)

[Dogfalo]

Looks like it is working now. I merged it in. Thanks again for your help :)

[NewBo1234]

Please....what was the fix? This is something I desperately need. Where can I look at the code?

[robinbortlik]

@NewBo1234 , what is the issue you have?
I have tested demo page and it seems to work: https://materializecss.com/select.html
Try to focus select box and use arrow up and down.

[NewBo1234]

Good morning,

I have 2 problems:

1. I'd like to look at the code, but when I got to the pull request, I get a 404 error. Does this mean that it is in a version already? At 2015, I think I should have already gotten a taste of the fix, but I cannot verify.

2. I'm on 97.5 (which is a pain right now) and when I go to my Navigation bar or to a dropdown, I can tab to the dropdown control, the control expands, and then nothing is highlighted and there doesn't appear to be any way to select when you use the arrow keys. With a mouse, of course it is the same flawless performance as expected, but for my accessibility testing, I have to be able to tab/enter/arrow through everything.

I like this library very much, but the accessibility tweaking is turning into a nightmare.

Thank you,
NewBo

[robinbortlik]

Hi @NewBo1234 ,

this is a commit which added a functionality: ec69063
Can you access the page?

Regarding to your second issue, I'm afraid, that you will have to investigate by yourself. I remember that times when I was working on this library, I had to pull it locally, update a code as I needed and then compile it for myself.