Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More templates #613

Merged
merged 33 commits into from
Nov 4, 2024
Merged

More templates #613

merged 33 commits into from
Nov 4, 2024

Conversation

SashaGoncharov19
Copy link
Contributor

@SashaGoncharov19 SashaGoncharov19 commented Oct 27, 2024

Influxdb template.
Infisical template.
Docmost template.
Vaultwarden template.
Hi.events template.
Windows (dockerized) template.
MacOS (dockerized) template.

Gitea 1.22.2 -> 1.22.3
Uptime Kuma 1.21.4 -> 1.23.15
Soketi v1.4-16 -> v1.6.1-16
NocoDB 0.251.1 -> 0.257.2

@SashaGoncharov19 SashaGoncharov19 marked this pull request as draft October 29, 2024 19:38
@ohkimur
Copy link

ohkimur commented Oct 30, 2024

@SashaGoncharov19 Awesome work man! You can also update nocodb version.

# Conflicts:
#	apps/dokploy/templates/templates.ts
@SashaGoncharov19 SashaGoncharov19 marked this pull request as ready for review November 1, 2024 22:08
@SashaGoncharov19
Copy link
Contributor Author

@Siumauricio ready for review.

Comment on lines 10 to 11
ports:
- 11001:80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this template and it doesn't work, also I tried to remove the expose port, is there any way you are exposing this port?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
So strange, in internal network works fine.

Copy link
Contributor

@Siumauricio Siumauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all the templates and looks good and is working, the only template are not working is the bitwarden

Can you check the images of these templates looks like are broken?

image

@SashaGoncharov19
Copy link
Contributor Author

SashaGoncharov19 commented Nov 3, 2024

Can you check the images of these templates looks like are broken?

@Siumauricio This apps don't have any logo. So I just not uploaded them. Idk what to do

@mezotv
Copy link
Contributor

mezotv commented Nov 3, 2024

@Siumauricio This apps don't have any logo. So I just not uploaded them. Idk what to do

These apps do have logos I added them in a pr on your repo so they can be merged into here SashaGoncharov19#1

@ohkimur
Copy link

ohkimur commented Nov 4, 2024

@SashaGoncharov19 @Siumauricio This might be a bit off topic, but I think if we extend the templates to include as many as possible from lists like this will give the new users to dokploy a serious great experience. Maybe it would be nice to organize sets of pull requests based on various categories.

@mezotv
Copy link
Contributor

mezotv commented Nov 4, 2024

@SashaGoncharov19 @Siumauricio This might be a bit off topic, but I think if we extend the templates to include as many as possible from lists like this will give the new users to dokploy a serious great experience. Maybe it would be nice to organize sets of pull requests based on various categories.

Better to get this pr merged before thinking about the next 100 templates

Copy link
Contributor

@Siumauricio Siumauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR!

@Siumauricio
Copy link
Contributor

@ohkimur

Sounds like a good idea, would you be interested in making a list of templates and create an issue with the templates that are needed so we can keep track of them easier?

Because I see certain items in that list that as such are projects and not docker images, for example Docusaurus, that is deployed as a project and not as a docker image.

@Siumauricio Siumauricio merged commit dfa73a3 into Dokploy:canary Nov 4, 2024
3 checks passed
@ohkimur
Copy link

ohkimur commented Nov 4, 2024

@Siumauricio

  1. List Creation: I can create a list to assist with organizing the templates, no problem.

  2. Clarification Needed: I’m not entirely sure I understand the second part of your comment. Could you clarify the differences you're referring to?

  3. Dokploy Template Structure: I haven’t yet closely examined the structure of Dokploy templates, but I noticed that the definitions are written in TypeScript files. Since this list could become quite extensive over time, I’m wondering:

    • Search Functionality: Are there any strategies in place for searching within the list?
    • Search Criteria: Does it currently search by title, description, tags, or something else?
  4. Suggestions for Template Details: What additional information would be helpful to include for each template to make this list more useful?

@Siumauricio
Copy link
Contributor

@ohkimur

  1. In reference to the second paragraph, I meant that in the link you shared there are certain items that cannot be abstracted as a template in dokploy, I put the case of docusaurus which is an application and is not distributed as a docker image.

  2. The composition of a template is divided into 3 steps

  3. Create the docker compose file

  4. Create the entrypoint of the docker compose which is a typescript file. This is where the domains, volumes, environment variables, etc. are defined.

  5. Add the metadata such as title, description, links, tags, to a typescript object.

Yes, currently you can search by title, and there is a select to filter by Tag.

  1. What I would like is to provide certain instructions in each template, because many times there are templates that have a defined user and password, and for the user could be difficult to find those details, so before creating the template would be ideal to show a more detailed screen with everything that comes by default, for example the credentials and if you need to assign an environment variable more in order to make work the template

@ohkimur
Copy link

ohkimur commented Nov 4, 2024

@Siumauricio I hope #650 works well.

@Siumauricio Siumauricio mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants