FIX TakePOS receipt preview in admin #25648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receipt preview in admin shows header and footer repeating themselves because in preview, `$constFreeText` equals `TAKEPOS_HEADER` (as there is no `$_SESSION['takeposterminal']` defined).
|
@eldy Should I also PR the same fix for 16.0, 17.0 and develop ? |
Max13
added a commit
to Max13/dolibarr
that referenced
this pull request
Aug 19, 2023
Receipt preview in admin shows header and footer repeating themselves because in preview, $constFreeText equals TAKEPOS_HEADER (as there is no $_SESSION['takeposterminal'] defined). Back compatibility for Dolibarr#25648
Max13
added a commit
to Max13/dolibarr
that referenced
this pull request
Aug 19, 2023
Receipt preview in admin shows header and footer repeating themselves because in preview, $constFreeText equals TAKEPOS_HEADER (as there is no $_SESSION['takeposterminal'] defined). Back compatibility for Dolibarr#25648
Max13
added a commit
to Max13/dolibarr
that referenced
this pull request
Aug 19, 2023
Receipt preview in admin shows header and footer repeating themselves because in preview, $constFreeText equals TAKEPOS_HEADER (as there is no $_SESSION['takeposterminal'] defined). Following Dolibarr#25648
|
When a fix is pushed for version x, it is also available for version x+1, x+2, ... and develop. Merges are done regularly to have fixes propagated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receipt preview in admin shows header and footer repeating themselves because in preview,
$constFreeTextequalsTAKEPOS_HEADER(as there is no$_SESSION['takeposterminal']defined).