Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX avoid sql error (issue #26342) #27643

Merged
merged 4 commits into from
Jan 21, 2024
Merged

FIX avoid sql error (issue #26342) #27643

merged 4 commits into from
Jan 21, 2024

Conversation

hregis
Copy link
Contributor

@hregis hregis commented Jan 19, 2024

No description provided.

@hregis hregis mentioned this pull request Jan 19, 2024
Closed
@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Jan 19, 2024
@eldy
Copy link
Member

eldy commented Jan 21, 2024

I see.
The problem is not in the missing field (there is no reason to have this field in the response since it is not used). The problem is in the use of the DISTINCT necessary because we use a join to make a filter on the sale representative instead of using a EXISTS. It has been fixed in v19. Can you fix by a backport of the fix of v19 ?

@hregis
Copy link
Contributor Author

hregis commented Jan 21, 2024

@eldy it's ok now, thank you

@eldy eldy merged commit 9e23700 into Dolibarr:18.0 Jan 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldy eldy eldy left review comments

Assignees
No one assigned
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hregis @eldy