Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in skill.class.php #29225

Closed
wants to merge 7 commits into from
Closed

Fix bug in skill.class.php #29225

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da3977f
After installation, when trying to register a company and select Spai…
rsanjoseo Mar 29, 2024
f0c10cf
After installation, when trying to register a company and select Spai…
rsanjoseo Mar 29, 2024
ef3f364
After installation, when trying to register a company and select Spai…
rsanjoseo Mar 29, 2024
6cbd0ff
Merge remote-tracking branch 'origin/develop' into develop
rsanjoseo Mar 29, 2024
1aff4b1
Merge remote-tracking branch 'origin/develop' into develop
rsanjoseo Apr 4, 2024
52f20f6
Merge remote-tracking branch 'origin/develop' into develop
rsanjoseo Apr 4, 2024
034cf53
Error in call to fetchAll is corrected in skill.class.php.
rsanjoseo Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions htdocs/hrm/class/skill.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<?php
/* Copyright (C) 2017 Laurent Destailleur <eldy@users.sourceforge.net>
* Copyright (C) 2021 Gauthier VERDOL <gauthier.verdol@atm-consulting.fr>
* Copyright (C) 2021 Greg Rastklan <greg.rastklan@atm-consulting.fr>
* Copyright (C) 2021 Jean-Pascal BOUDET <jean-pascal.boudet@atm-consulting.fr>
* Copyright (C) 2021 Grégory BLEMAND <gregory.blemand@atm-consulting.fr>
* Copyright (C) 2024 Frédéric France <frederic.france@free.fr>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
/* Copyright (C) 2017 Laurent Destailleur <eldy@users.sourceforge.net>
* Copyright (C) 2021 Gauthier VERDOL <gauthier.verdol@atm-consulting.fr>
* Copyright (C) 2021 Greg Rastklan <greg.rastklan@atm-consulting.fr>
* Copyright (C) 2021 Jean-Pascal BOUDET <jean-pascal.boudet@atm-consulting.fr>
* Copyright (C) 2021 Grégory BLEMAND <gregory.blemand@atm-consulting.fr>
* Copyright (C) 2024 Frédéric France <frederic.france@free.fr>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
* Copyright (C) 2024 Rafael San José <rsanjose@alxarafe.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
Expand Down Expand Up @@ -408,7 +409,7 @@
$this->lines = array();
require_once __DIR__ . '/skilldet.class.php';
$skilldet = new Skilldet($this->db);
$this->lines = $skilldet->fetchAll('ASC', '', '', '', 'fk_skill:=:'.$this->id, '');
$this->lines = $skilldet->fetchAll('ASC', '', '', 0,'', 'fk_skill:=:'.$this->id, '');

Check failure on line 412 in htdocs/hrm/class/skill.class.php

View workflow job for this annotation

GitHub Actions / pre-commit / pre-commit 

No space found after comma in argument list

Check warning on line 412 in htdocs/hrm/class/skill.class.php

View workflow job for this annotation

GitHub Actions / phan / Run phan 

skill.class.php: PhanParamTooMany: Call with 7 arg(s) to \Skilldet::fetchAll(string $sortorder = '', string $sortfield = '', int $limit = 0, int $offset = 0, string $filter = '', string $filtermode = 'AND') which only takes 6 arg(s) defined at htdocs/hrm/class/skilldet.class.php:357

if (is_array($this->lines)) {
return (count($this->lines) > 0) ? $this->lines : array();
Expand Down
Loading