throw RestException(500) if update of invoice fails #32134

[JonBendtsen]

FIX #32134 Updating Invoice Notes
throw RestException(500) if update of invoice fails

[JonBendtsen]

Even though @natalieboucher said it worked in version 19, I decided to make invoice API use same structure as order API, and from v18 because v18 are still released as LTS.

[JonBendtsen]

devcamp munich 2024

[frederic34]

@JonBendtsen it will throw a phan error in develop like in your closed PR
https://github.com/Dolibarr/dolibarr/pull/32189/files

[JonBendtsen]

it will throw a phan error in develop like in your closed PR

Are orders any different than invoices?

commande/class/api_orders.class.php

		if ($this->commande->update(DolibarrApiAccess::$user) > 0) {
			return $this->get($id);
		} else {
			throw new RestException(500, $this->commande->error);
		}

compta/facture/class/api_invoices.class.php

		if ($this->invoice->update(DolibarrApiAccess::$user) > 0) {
			return $this->get($id);
		} else {
			throw new RestException(500, $this->invoice->error);
		}

Because all I am doing is making the code pretty identical

The public function update( seems pretty similar between orders
https://github.com/Dolibarr/dolibarr/blob/develop/htdocs/compta/facture/class/facture.class.php#L2500

and invoices
https://github.com/Dolibarr/dolibarr/blob/develop/htdocs/commande/class/commande.class.php#L3349

Am I wrong in expecting that phan would also throw an error if the change was in the existing order code?

I also actually tested this code, and with it I do get an error in the API, where as without it I get http code 200 as if no errors

[rycks]

ok for me thanks !