fix #458 RadioGroup ignores setValue in readOnly-mode

DominoKit · Dec 22, 2024 · aebac16 · aebac16
1 parent 390c6b2
commit aebac16
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/Radio.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/Radio.java
@@ -93,7 +93,7 @@ public Radio(T value, String label) {
     withValue(value);
     EventListener listener =
         evt -> {
-          if (isEnabled() && !isChecked()) {
+          if (isEnabled() && !isChecked() && !isReadOnly()) {
             check();
           }
         };
@@ -273,7 +273,7 @@ private Radio<T> setChecked(boolean value, boolean silent) {
       return this;
     }
     if (nonNull(radioGroup)) {
-      if (!(radioGroup.isReadOnly() || radioGroup.isDisabled())) {
+      if (!radioGroup.isDisabled()) {
         T oldValue = (T) radioGroup.getValue();
         radioGroup.getRadios().stream()
             .filter(Radio::isChecked)
@@ -758,4 +758,9 @@ public T withRadioGroup(ChildHandler<Radio<T>, RadioGroup<? super T>> handler) {
     handler.apply(this, radioGroup);
     return (T) this;
   }
+
+  @Override
+  public boolean isReadOnly() {
+    return super.isReadOnly() || radioGroup.isReadOnly();
+  }
 }
diff --git a/...resources/org/dominokit/domino/ui/public/css/domino-ui/dui-components/domino-ui-forms.css b/...resources/org/dominokit/domino/ui/public/css/domino-ui/dui-components/domino-ui-forms.css
@@ -534,10 +534,15 @@ textarea.dui-field-input {
     --dui-accent-d-2: var(--dui-form-field-disabled-color-darker);
     pointer-events: none;
 }
+
 .dui-form-radio[disabled] .dui-radio-label{
     color: var(--dui-form-field-disabled-color);
 }
 
+.dui-form-radio-group[readonly] .dui-form-radio,
+.dui-form-radio[readonly] {
+    pointer-events: none;
+}
 
 .dui-form-radio {
     position: relative;