Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling clear value for multiselect box will repeat the call for change listener by the number of selected items. #939

Closed
howudodat opened this issue May 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Milestone

Comments

@howudodat
Copy link

if I have 3 items selected. I get at least 4 changed notifications plus a clear notification when delete is clicked. I think the intermediary change notifications are too much, only the final change and clear should be sent

In AbstractSelect line 209 calls clearValue(false)...in that function line 269 calls item.deselect(silent) which is false, so item.deselect() triggers discreet changeevents. changing it to item.deselect(true) prevents the discreet events, but I dont know what would be the unintended side efects of that change.

@vegegoku vegegoku self-assigned this Jun 25, 2024
@vegegoku vegegoku added the bug Something isn't working label Jun 25, 2024
@vegegoku vegegoku added this to the 2.0.2 milestone Jun 25, 2024
@vegegoku vegegoku changed the title AbstractSelect calls changelisteners in clear when it shouldn't V2 calling clear value for multiselect box will repeat the call for change listener by the number of selected items. Jul 14, 2024
@vegegoku vegegoku added the version 2.x.x Version 2.x.x issues label Jul 14, 2024
vegegoku added a commit that referenced this issue Jul 14, 2024
… for change listener by the number of selected items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Projects
Status: Done
Development

No branches or pull requests

2 participants