Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals #1052

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Modals #1052

merged 4 commits into from
Nov 22, 2024

Conversation

DonDebonair
Copy link
Owner

No description provided.

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 88.77193% with 32 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (e2dd795) to head (2cfba31).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
machine/plugins/modals.py 77.77% 10 Missing ⚠️
machine/clients/slack.py 52.94% 8 Missing ⚠️
machine/plugins/base.py 61.53% 5 Missing ⚠️
machine/handlers/interactive_handler.py 92.30% 4 Missing ⚠️
machine/plugins/block_action.py 77.77% 2 Missing ⚠️
machine/storage/backends/dynamodb.py 0.00% 2 Missing ⚠️
machine/plugins/command.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   78.93%   79.71%   +0.78%     
==========================================
  Files          34       36       +2     
  Lines        1761     1957     +196     
==========================================
+ Hits         1390     1560     +170     
- Misses        371      397      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DonDebonair DonDebonair force-pushed the feat/modals branch 2 times, most recently from 481ec56 to 1c5fa85 Compare May 31, 2024 18:59
@DonDebonair DonDebonair force-pushed the feat/modals branch 8 times, most recently from b13a768 to 8927815 Compare November 22, 2024 14:41
@DonDebonair DonDebonair force-pushed the feat/modals branch 2 times, most recently from e0e2e84 to 02cc41f Compare November 22, 2024 15:49
- Add plugin methods for creating and updating modals and publishing the app home tab
- Add models for view submissions and views closed
- Add decorators for modals
- Register modal handlers during plugin registration
- Handle view submission and closed events
- Add convenience methods to interaction models

  The following interaction models have convenience methods for dealing with modals:

  - `ModalSubmission` has methods for updating the submitted modal, pushing a new view or opening a
    new modal. It also has a method to send DMs to the user that submitted the modal
  - `ModalClosure` has a method to send DMs to the user that closed the modal
  - `BlockAction` now lets you send a DM to the user that triggered the block action or open a
    modal

feat: expose open_im for plugins

docs: document modal-related functionality
@DonDebonair DonDebonair marked this pull request as ready for review November 22, 2024 15:53
@DonDebonair DonDebonair merged commit 96527ba into main Nov 22, 2024
8 checks passed
@DonDebonair DonDebonair deleted the feat/modals branch November 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant