async display of linting results (#190) #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jabooth , sweet and simple. |
|
|
||
| // Build the message and suffix the message with the name of the linter used | ||
| msgs.forEach(d => { | ||
| d.message = `${d.message}`; |
There was a problem hiding this comment.
@DonJayamanne I kept this line from the previous code but it doesn't make sense to me - as d.message is a string, surely:
d.message === `${d.message}`so this is a no-op?
|
@jabooth , ha ha... I know how that got in there. I just remove it. Thanks again |
|
@DonJayamanne haha cool, no worries! Just wanted to check I wasn't missing something super subtle 😅 |
DonJayamanne
added a commit
that referenced
this pull request
Nov 21, 2017
* Fix microsoft/vscode#37627 (#1368) * Version 0.7.0 of extension (#1381) Archive of 0.7.0 * Update README.md * Update README.md * fix readme * merged upstream * disable linting upon extension load
DonJayamanne
added a commit
that referenced
this pull request
Nov 21, 2017
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates listing results on the fly as each linter reports rather than waiting for all at once (closing #190)
On a large file:
