-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#76 spool list, no reload on page change #172
Conversation
clevelandcs
commented
Oct 25, 2023
•
edited
Loading
edited
- Completes requested feature from Show all filament spools in the filament page #76 adding filtered route link to end of record as "Spool List" alternate name suggestions "Show Spools", "List Spools", "View Spools", etc
- Replaces href link for show Vendor with React router navigate function to avoid unnecessary reload of the SPA
- Requested feature Set default Value in Create Filament and "Save and Continue" Option #101 Save and continue button on Spool Create- added to all 3 resources so footer buttons are consistent across app
- Add input to the footer for adding an arbitrary number of spools of the same filament on Spool Create - reduces the tedium when receiving a shipment of 20 spools of the same black
- Fix regression of filter URL containing empty filters due to using state filters instead of filtered filters list
Very nice additions, thank you! Just a few minor comments to address before merge. |
Found another issue after some more testing, I get the "are you sure you want to leave and lose your changes?" popup when I click the regular save button now on the spool create page after I've set the quantity to more than 1. |
Hmm, that seems like it could be a bit difficult to work around. I don't see anything builtin to disable that. Just a quick search seemed to suggest I'll need to add a bunch of js to override the default behavior to ignore just that one field. |
Update: Ok, there's simply a "warnWhenUnsavedChanges" property on useForm that can be set to false. Setting this to false disables the default unsaved warning seems like this is a fine way forward at least as far as the negligible data entry that could need to be reentered if someone accidentally did refresh or navigate away from the page. |
sounds good to me! |