Create install_arch.sh #335
Conversation
|
Thank you! I see a lot of similarities between this and the debian one, perhaps the script can be split up into several scripts and then having common parts be located in some |
|
Hi, yes you are right i think some common stuff can be factorized into something as mentioned. I didn't want to take the initiative of this but i can give it a try if you want. |
|
Yes please do :) |
|
It seems like the pip install pdm
pdm export -o requirements.txt --without-hashes > requirements.txtlines to the generic installer ? |
|
requirements.txt is generated in the CI job (to the root dir) to prevent people from needing to install pdm, which has proved to have quite annoying dependencies on some systems. So that cannot really be changed. |
|
Hi, i updated the script and updated the README accordingly. Is there a way to ensure it works without me having to setup a VM ? |
| echo -e "${ORANGE}Your operating system is not supported. Either try to install manually or reach out to spoolman github for support.${NC}" | ||
| exit 1 | ||
| fi | ||
| fi |
There was a problem hiding this comment.
If /etc/os-release is not available it should also fail
I can test it for you on debian |
scripts/install.sh
Outdated
| sudo apt-get update || exit 1 | ||
| if [[ -f /etc/os-release ]]; then | ||
| source /etc/os-release | ||
| if [[ "$ID_LIKE" == *"debian"* ]]; then |
There was a problem hiding this comment.
Turns out on Debian itself, ID_LIKE doesn't exist, only ID does, which is "debian". So you should check for either ID_LIKE like you do here, or "$ID" == *"debian"*
There was a problem hiding this comment.
I check for both ID and ID_LIKE variables, this should do the trick for you.
|
Looks good now and seems to work fine, thank you! |
I had this script working on a endeavourOS machine.