Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support helmrelease secret values #43

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat: support helmrelease secret values #43

merged 1 commit into from
Jul 11, 2023

Conversation

raffis
Copy link
Member

@raffis raffis commented Jul 11, 2023

Current situation

HelmRelease secret values are not supported yet.

Proposal

Support secret values with a hint how to deal with encrypted secrets.

@raffis raffis requested a review from a team as a code owner July 11, 2023 07:30
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5517078859

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 69.157%
Files with Coverage Reduction New Missed Lines %
internal/worker/pool.go 3 86.75%
Totals Coverage Status
Change from base Build 5473541114: -0.1%
Covered Lines: 1740
Relevant Lines: 2516
💛 - Coveralls

@raffis raffis merged commit feabaf1 into master Jul 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paride5745 paride5745 paride5745 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raffis @paride5745