Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #70 and supports CRDsPolicy Skip #71

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

yoadey
Copy link
Contributor

@yoadey yoadey commented Oct 17, 2023

Fixes two issues with HelmReleases:

  • If no namespace is set in the chart source, the same namespace as the HelmRelease should be used
  • SkipCRDs is deprecated and is replaced by CRDs Skip Policy

@yoadey yoadey requested a review from a team as a code owner October 17, 2023 12:20
Copy link
Member

@raffis raffis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution.

@raffis raffis merged commit 222f88a into DoodleScheduling:master Oct 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants