Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] #85

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/sigstore/cosign v1.13.1 -> v1.13.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-46737

Summary

Cosign is susceptible to a denial of service by an attacker controlled registry. An attacker who controls a remote registry can return a high number of attestations and/or signatures to Cosign and cause Cosign to enter a long loop resulting in an endless data attack. The root cause is that Cosign loops through all attestations fetched from the remote registry in pkg/cosign.FetchAttestations.

The attacker needs to compromise the registry or make a request to a registry they control. When doing so, the attacker must return a high number of attestations in the response to Cosign. The result will be that the attacker can cause Cosign to go into a long or infinite loop that will prevent other users from verifying their data. In Kyvernos case, an attacker whose privileges are limited to making requests to the cluster can make a request with an image reference to their own registry, trigger the infinite loop and deny other users from completing their admission requests. Alternatively, the attacker can obtain control of the registry used by an organization and return a high number of attestations instead the expected number of attestations.

The vulnerable loop in Cosign starts on line 154 below:
https://github.com/sigstore/cosign/blob/004443228442850fb28f248fd59765afad99b6df/pkg/cosign/fetch.go#L135-L196

The l slice is controllable by an attacker who controls the remote registry.

Many cloud-native projects consider the remote registry to be untrusted, including Crossplane, Notary and Kyverno. We consider the same to be the case for Cosign, since users are not in control of whether the registry returns the expected data.

TUF's security model labels this type of vulnerability an "Endless data attack", but an attacker could use this as a type of rollback attack, in case the user attempts to deploy a patched version of a vulnerable image; The attacker could prevent this upgrade by causing Cosign to get stuck in an infinite loop and never complete.

Mitigation

The issue can be mitigated rather simply by setting a limit to the limit of attestations that Cosign will loop through. The limit does not need to be high to be within the vast majority of use cases and still prevent the endless data attack.


Release Notes

sigstore/cosign (github.com/sigstore/cosign)

v1.13.2

Compare Source

What's Changed

Full Changelog: sigstore/cosign@v1.13.1...v1.13.2


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner November 8, 2023 17:10
@renovate renovate bot added the security label Nov 8, 2023
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed Nov 10, 2023
@renovate renovate bot closed this Nov 10, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 10, 2023 01:30
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v2 [security] Nov 10, 2023
@renovate renovate bot reopened this Nov 10, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 10, 2023 04:22
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from 125972a to d60d721 Compare November 10, 2023 04:25
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed Nov 10, 2023
@renovate renovate bot closed this Nov 10, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 10, 2023 13:36
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v2 [security] Nov 11, 2023
@renovate renovate bot reopened this Nov 11, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 11, 2023 10:45
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from d60d721 to af6bb58 Compare November 11, 2023 10:47
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed Nov 11, 2023
@renovate renovate bot closed this Nov 11, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 11, 2023 14:09
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v2 [security] Nov 11, 2023
@renovate renovate bot reopened this Nov 11, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 11, 2023 16:52
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from af6bb58 to 2287a46 Compare November 11, 2023 16:55
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed Nov 11, 2023
@renovate renovate bot closed this Nov 11, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 11, 2023 19:21
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v2 [security] Nov 11, 2023
@renovate renovate bot reopened this Nov 11, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch November 11, 2023 21:03
@renovate renovate bot closed this Dec 8, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 8, 2023 09:29
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] Dec 9, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 9, 2023 04:57
@renovate renovate bot reopened this Dec 9, 2023
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from 1efe16f to 4473324 Compare December 9, 2023 04:58
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed Dec 9, 2023
@renovate renovate bot closed this Dec 9, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 9, 2023 06:42
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] Dec 9, 2023
@renovate renovate bot reopened this Dec 9, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 9, 2023 09:59
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from 4473324 to b198829 Compare December 9, 2023 10:00
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed Dec 9, 2023
@renovate renovate bot closed this Dec 9, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 9, 2023 13:18
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] Dec 10, 2023
@renovate renovate bot reopened this Dec 10, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 10, 2023 15:08
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from b198829 to 36cac72 Compare December 10, 2023 15:09
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed Dec 10, 2023
@renovate renovate bot closed this Dec 10, 2023
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 10, 2023 19:45
@renovate renovate bot changed the title chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] - autoclosed chore(deps): update module github.com/sigstore/cosign to v1.13.2 [security] Dec 11, 2023
@renovate renovate bot restored the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 11, 2023 18:06
@renovate renovate bot reopened this Dec 11, 2023
@renovate renovate bot force-pushed the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch from 36cac72 to 0fd2cf0 Compare December 11, 2023 18:07
@raffis raffis merged commit 252f249 into master Dec 20, 2023
5 checks passed
@renovate renovate bot deleted the renovate/go-git.luolix.top/sigstore/cosign-vulnerability branch December 20, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant