Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: allow values from secret to be in stringData #86

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

LittleFox94
Copy link
Contributor

While Kubernetes only stores data and not stringData, a GitOps repository might contain Secret manifests with stringData, this commit makes flux-build use that if the requested key is not found in data.

While Kubernetes only stores `data` and not `stringData`, a GitOps
repository might contain Secret manifests with `stringData`, this commit
makes flux-build use that if the requested key is not found in `data`.
@LittleFox94 LittleFox94 requested a review from a team as a code owner November 27, 2023 13:12
Copy link
Member

@raffis raffis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution!

@raffis raffis merged commit b994c3b into DoodleScheduling:master Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants