Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-base64 encoded secret #97

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Support non-base64 encoded secret #97

merged 1 commit into from
Apr 2, 2024

Conversation

dud225
Copy link
Contributor

@dud225 dud225 commented Mar 27, 2024

No description provided.

@dud225 dud225 requested a review from a team as a code owner March 27, 2024 16:38
raffis
raffis requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@raffis raffis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this!

Makes sense to me although we should cover the very edge case somebody sets a plain key for either of them. Also StringData is a typed string, no need to wrap it with string().

internal/helm/registry/auth.go Outdated Show resolved Hide resolved
@dud225 dud225 requested a review from raffis March 28, 2024 09:06
@coveralls
Copy link

coveralls commented Mar 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8469245835

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.967%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/helm/registry/auth.go 8 10 80.0%
Totals Coverage Status
Change from base Build 7900520352: 0.02%
Covered Lines: 1749
Relevant Lines: 2536
💛 - Coveralls

@raffis
Copy link
Member

raffis commented Mar 28, 2024

Could you pls run a go fmt/make fmt on this one? otherwise lgtm.

@dud225
Copy link
Contributor Author

dud225 commented Mar 28, 2024

sorry for that, done

@raffis
Copy link
Member

raffis commented Apr 2, 2024

Thanks for raising this 🙏🏻

@raffis raffis merged commit e6ac985 into DoodleScheduling:master Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raffis raffis raffis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dud225 @coveralls @raffis