Feedback

DotNetAnalyzers · Dec 19, 2023 · 6e752bb · 6e752bb
1 parent 3800377
commit 6e752bb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
@@ -6,7 +6,6 @@ namespace StyleCop.Analyzers.Test.DocumentationRules
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.CodeAnalysis.Testing;
-    using Microsoft.VisualBasic.Devices;
     using StyleCop.Analyzers.DocumentationRules;
     using StyleCop.Analyzers.Test.Helpers;
     using StyleCop.Analyzers.Test.Verifiers;
@@ -215,6 +214,7 @@ public async Task TestTypeWithEmptyBaseListAndCrefAttributeAsync(string declarat
         }
 
         [Theory]
+        [InlineData("Test(int ignored) { }")]
         [InlineData("void Foo() { }")]
         [InlineData("string foo;")]
         [InlineData("string Foo { get; set; }")]

diff --git a/...rs/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs b/...rs/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
@@ -225,12 +225,10 @@ private static void HandleMemberDeclaration(SyntaxNodeAnalysisContext context)
         /// <returns><see langword="true"/> if any base type constructor's signature matches the signature of <paramref name="constructorMethodSymbol"/>, <see langword="false"/> otherwise.</returns>
         private static bool HasMatchingSignature(ImmutableArray<IMethodSymbol> baseConstructorSymbols, IMethodSymbol constructorMethodSymbol)
         {
-            bool found = false;
-
             foreach (IMethodSymbol baseConstructorMethod in baseConstructorSymbols)
             {
                 // Constructors must have the same number of parameters.
-                if (constructorMethodSymbol.Parameters.Count() != baseConstructorMethod.Parameters.Count())
+                if (constructorMethodSymbol.Parameters.Length != baseConstructorMethod.Parameters.Length)
                 {
                     continue;
                 }
@@ -252,12 +250,11 @@ private static bool HasMatchingSignature(ImmutableArray<IMethodSymbol> baseConst
 
                 if (success)
                 {
-                    found = true;
-                    break;
+                    return true;
                 }
             }
 
-            return found;
+            return false;
         }
 
         private static bool HasXmlCrefAttribute(XmlNodeSyntax inheritDocElement)