Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1101 in property pattern #3472

Closed
JohanLarsson opened this issue Mar 21, 2022 · 1 comment · Fixed by #3483
Closed

SA1101 in property pattern #3472

JohanLarsson opened this issue Mar 21, 2022 · 1 comment · Fixed by #3483
Labels
bug c# 10 fixed
Milestone
1.2.0-beta.435

Comments

@JohanLarsson
Copy link

image

internal object? P=> this.Value switch
{
    InvocationExpressionSyntax { Expression: LiteralExpressionSyntax { Token.ValueText: { } valueText } } =>null,
    _ => null,
};
@springy76
Copy link

Happens right after IDE0170 "simplify property pattern" - a C#10 feature?

BTW a simple if is enough:
if(something is { Page.PageNumber: > 1 })

sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Apr 18, 2022
@sharwell
Support extended property patterns in SA1101
8d274a9 
Fixes DotNetAnalyzers#3472
@sharwell sharwell mentioned this issue Apr 18, 2022
Merged
@sharwell sharwell added this to the 1.2-beta.next milestone Apr 18, 2022
@sharwell sharwell added the fixed label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug c# 10 fixed
Projects
None yet
Milestone
1.2.0-beta.435
Development

Successfully merging a pull request may close this issue.

Support extended property patterns in SA1101 sharwell/StyleCopAnalyzers
3 participants
@sharwell @JohanLarsson @springy76