Enable tests for code fix behavior with alternate indentation #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The per-language options used by the AdhocWorkspace are currently shared. This is caused by the default constructor of AdhocWorkspace using MefHostServices.DefaultHost to provide workspace services, combined with Workspace.WithChangedOption setting values back to the host. In theory, all tests which run using the default options could be run in parallel, and only serialize the tests which use custom options. However, we don't have a mechanism in place to handle this currently, so disabling test parallelization allows us to improve overall test quality immediately (by testing alternate indentation options in some scenarios).
|
👍 |
sharwell
added a commit
that referenced
this pull request
Aug 6, 2015
Enable tests for code fix behavior with alternate indentation
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to address the original reliability problems by disabling test parallelization. It did not appear to have an effect on the overall build and test time.