Adds codefix that creates default settings file #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vweijsters
commented
Aug 19, 2015
vweijsters
commented
- Fixes Create a code fix which adds a default settings file to the project #1241
| SA1634FileHeaderMustShowCopyright.DiagnosticId, | ||
| SA1635FileHeaderMustHaveCopyrightText.DiagnosticId, | ||
| SA1636FileHeaderCopyrightTextMustMatch.DiagnosticId, | ||
| SA1637FileHeaderMustContainFileName.DiagnosticId, |
There was a problem hiding this comment.
❓ Does this one rely on settings?
|
@sharwell I added all the file header diagnostics, under the assumption that a single codefix will be made that addresses all of these. That single codefix would ofcourse need the settings. |
vweijsters
force-pushed
the
settings-file-codefix
branch
from
42eafa7
to
a3eb863
Compare
|
@vweijsters I'm reviewing this right now. Don't worry about merging it to fix the conflicts as I've already taken care of it. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.