Multi-file code fix verification #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach (var code in fixedCode) | ||
| { | ||
| await this.VerifyCSharpDiagnosticAsync(code.Replace("%1", this.Keyword), EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false); | ||
| } |
There was a problem hiding this comment.
💭 This code construction is repeated a lot. Might be a good idea to add a VerifyNoCSharpDiagnosticsAsync method that will accept either a source file or a list of sources.
There was a problem hiding this comment.
Turns out, the overload exists. I'll update.
|
👍 Looks good to me, only one small remark. |
sharwell
added a commit
that referenced
this pull request
Jul 14, 2016
Multi-file code fix verification
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for verifying code fixes that affect more than one file.