Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple type parentheses handling #2478

Merged
merged 3 commits into from
Jun 28, 2017

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 26, 2017

Fixes #2472
Fixes #2476
Fixes #2479

@sharwell sharwell added this to the 1.1.0 Beta 5 milestone Jun 26, 2017
@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #2478 into master will increase coverage by 0.07%.
The diff coverage is 98.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
+ Coverage   97.21%   97.28%   +0.07%     
==========================================
  Files         735      735              
  Lines       94995    95255     +260     
  Branches     3470     3472       +2     
==========================================
+ Hits        92347    92668     +321     
+ Misses       1751     1746       -5     
+ Partials      897      841      -56
Impacted Files Coverage Δ
...s/SA1008OpeningParenthesisMustBeSpacedCorrectly.cs 100% <100%> (+2.02%) ⬆️
...s/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs 100% <100%> (+0.97%) ⬆️
...est.CSharp7/SpacingRules/SA1009CSharp7UnitTests.cs 100% <100%> (ø) ⬆️
...est.CSharp7/SpacingRules/SA1008CSharp7UnitTests.cs 100% <100%> (ø) ⬆️
...ers/StyleCop.Analyzers/Helpers/TypeSyntaxHelper.cs 68.42% <100%> (+18.42%) ⬆️
...leCop.Analyzers.Test/Helpers/MetadataReferences.cs 75% <69.23%> (-19.12%) ⬇️
...A1004DocumentationLinesMustBeginWithSingleSpace.cs 65.62% <0%> (ø) ⬆️
...es/DocumentationRules/FileHeaderCodeFixProvider.cs 96.96% <0%> (+0.33%) ⬆️
...alyzers/StyleCop.Analyzers/Helpers/TriviaHelper.cs 84.12% <0%> (+0.33%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000b45d...0ccaad4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants