Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1119 handling of 'with' expressions #3263

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 5, 2020

Fixes #3239

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #3263 (9715fc0) into master (363a36c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3263   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files        1001     1002    +1     
  Lines      109640   109695   +55     
  Branches     3722     3724    +2     
=======================================
+ Hits       102492   102550   +58     
+ Misses       6218     6215    -3     
  Partials      930      930           

@sharwell sharwell added this to the 1.2-beta.next milestone Dec 5, 2020
@sharwell sharwell merged commit 9b285fc into DotNetAnalyzers:master Dec 5, 2020
@sharwell sharwell deleted the parenthesized-with branch December 5, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on SA1119 for 'with' expression
1 participant