Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support implicit object creation expressions in SA1129 code fix #3278

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 21, 2020

Fixes #3277

Thanks to @danmosemsft for the initial test here 👍

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #3278 (46d2e37) into master (c8ce94b) will increase coverage by 0.01%.
The diff coverage is 94.23%.

@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
+ Coverage   93.53%   93.55%   +0.01%     
==========================================
  Files        1015     1017       +2     
  Lines      109983   110022      +39     
  Branches     3783     3786       +3     
==========================================
+ Hits       102872   102930      +58     
+ Misses       6162     6141      -21     
- Partials      949      951       +2     

@sharwell sharwell merged commit f262c13 into DotNetAnalyzers:master Dec 21, 2020
@sharwell sharwell deleted the Fix3277 branch December 21, 2020 18:52
@sharwell sharwell added this to the 1.2-beta.next milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidCastException requesting fixes for SA1129 on target typed new
2 participants