Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom fix all providers #3322

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

sharwell
Copy link
Member

Implement document-based fix all providers for:

  • SA1506
  • SA1509
  • SA1510
  • SA1511
  • SA1513
  • SA1514

Based on information found in https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1293538.

@sharwell
Copy link
Member Author

@RussKie this should fix the specific problems you saw.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3322 (3be581f) into master (ab5993f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3be581f differs from pull request most recent head 6ac3ef3. Consider uploading reports for the commit 6ac3ef3 to get more accurate results

@@           Coverage Diff           @@
##           master    #3322   +/-   ##
=======================================
  Coverage   93.53%   93.54%           
=======================================
  Files        1021     1021           
  Lines      110375   110463   +88     
  Branches     3813     3813           
=======================================
+ Hits       103237   103330   +93     
+ Misses       6179     6175    -4     
+ Partials      959      958    -1     

@RussKie
Copy link

RussKie commented Mar 17, 2021

Thank you for the quick turnaround!
How can I test these?

@sharwell sharwell merged commit 4d9b3e3 into DotNetAnalyzers:master Mar 17, 2021
@sharwell sharwell deleted the custom-fix branch March 17, 2021 22:12
@sharwell sharwell added this to the 1.2-beta.next milestone Mar 17, 2021
@sharwell
Copy link
Member Author

@RussKie Locally you could use this feed:

<!-- Uncomment this to test unpublished builds from the AppVeyor feed. -->
<!--<add key="appveyor-stylecop" value="https://ci.appveyor.com/nuget/stylecopanalyzers" />-->

Version 1.2.0-beta.343 should have the fix for validation.

@sharwell
Copy link
Member Author

@RussKie these are now part of the latest preview release!

@RussKie
Copy link

RussKie commented Jun 18, 2021

Awesome! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants