Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file-scoped namespaces in SA1649 and SA1402 #3436

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

sharwell
Copy link
Member

Fixes #3435

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #3436 (6464966) into master (88d9d3f) will increase coverage by 3.27%.
The diff coverage is 100.00%.

❗ Current head 6464966 differs from pull request most recent head e1f52bf. Consider uploading reports for the commit e1f52bf to get more accurate results

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   89.86%   93.13%   +3.27%     
==========================================
  Files        1045     1047       +2     
  Lines      108919   112349    +3430     
  Branches     3976     3976              
==========================================
+ Hits        97876   104633    +6757     
+ Misses       9971     6649    -3322     
+ Partials     1072     1067       -5     

@sharwell sharwell merged commit a821966 into DotNetAnalyzers:master Jan 14, 2022
@sharwell sharwell deleted the file-namespaces branch January 14, 2022 19:40
@sharwell sharwell added this to the 1.2-beta.next milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1649 and SA1402 - Doesn't work when using C# 10 File-scoped Namespaces
1 participant