Fix false positive in SA1516 between global statements #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3482 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 1063 1063
Lines 113088 113132 +44
Branches 3979 3980 +1
=======================================
+ Hits 105438 105482 +44
Misses 6630 6630
Partials 1020 1020 |
sharwell
reviewed
Apr 18, 2022
Comment on lines
+107
to
+111
| // /0/Test0.cs(2,1): warning SA1516: Elements should be separated by blank line | ||
| Diagnostic().WithLocation(0), | ||
|
|
||
| // /0/Test0.cs(2,1): warning SA1516: Elements should be separated by blank line | ||
| Diagnostic().WithLocation(0), |
There was a problem hiding this comment.
❔ Do we know why this is reported twice?
There was a problem hiding this comment.
It's also reported twice in the first test in this file (from which I copied this one), so it's an existing behavior.
Not sure why it's reposted twice (or even is it actually reported twice, or it's a test system issue)
sharwell
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3351