Fix an off by one in our test code #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +196,7 @@ private static void VerifyDiagnosticLocation(DiagnosticAnalyzer analyzer, Diagno | |||
| var actualLinePosition = actualSpan.StartLinePosition; | |||
|
|
|||
| // Only check line position if there is an actual line in the real diagnostic | |||
| if (actualLinePosition.Line > 0) | |||
| if (actualLinePosition.Line >= 0) | |||
There was a problem hiding this comment.
❗ The bug is actually that actualLinePosition is used here. The original intent was for the user to be able to specify in the expected results that the line doesn't matter. The condition should be this:
if (expected.Line > 0)💡 The documentation for DiagnosticResultLocation could be improved to more clearly state that the line and column numbers are 1-based, along with clarifying the meaning of 0.
|
I implemented the CR feedback and im creating a roslyn issue now. |
sharwell
added a commit
that referenced
this pull request
Mar 27, 2015
Fix an off by one in our test code
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567.