-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement generics related documentation rules #873
Conversation
@@ -28,13 +34,16 @@ public class SA1620GenericTypeParameterDocumentationMustMatchTypeParameters : Di | |||
/// </summary> | |||
public const string DiagnosticId = "SA1620"; | |||
private const string Title = "Generic type parameter documentation must match type parameters"; | |||
private const string MessageFormat = "TODO: Message format"; | |||
private const string MessageFormat = "{0}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 You can create two DiagnosticDescriptor
instances that have the same ID but different message formats. Only return one of them from SupportedDiagnostics
but the other can still be used when the second message is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will change that
This implements all documentation rules for generics
Fixes #138.
Fixes #139.
Fixes #140.
Fixes #141.
Fixes #142.