Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SRS being created multiple times for a kanji #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

levi-rocha
Copy link

@levi-rocha levi-rocha commented Nov 25, 2020

Fixes #5

I was able to pinpoint how #5 happens. Steps to reproduce:

  1. Search for any 2+ Kanji compound in vocab tab
  2. Click on one of the kanji
  3. Add this kanji to SRS
  4. From kanji list on the right, click the other kanji then the original kanji again - Add button is there as if kanji was not already added, which lets user add it to their SRS again

Was able to fix this by reapplying the filter when a kanji is selected from the list.

I rebase this branch onto your master so you can choose to merge it before #24 since this is a more simple change. Whichever one you merge last might require a rebase

Update: Added another commit to also fix the issue when navigating from the vocab list. Did this by adding an instance of KanjiDao the NavigationActor singleton can use to refresh a kanji when navigating to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double entry in SRS database
1 participant