Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to extract layer names from Chain, Parallel and SkipConnection #95

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

DrChainsaw
Copy link
Owner

Fixes #94

This adds functionality to extract layer names from Chain, Parallel and SkipConnection.

This functionality is enabled by default, meaning that if the model to be serialized is a Chain with named layers, ONNXNaiveNASflux will use those names instead of the default ones. The name hunting will recurse to any nested Chains and into Parallels and SkipConnections.

@alicewith: You can see some examples of what this does in the tests, starting here.

Note that the input node is a special node in ONNX which does not exist in a Flux Chain, so just naming the first layer "input" will not give you the result you want; You have to give the name as input to save just as on current master.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.18%. Comparing base (63d5faf) to head (ad1de43).

Files Patch % Lines
src/serialize/namingutil.jl 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   96.12%   96.18%   +0.05%     
==========================================
  Files          15       15              
  Lines        1109     1152      +43     
==========================================
+ Hits         1066     1108      +42     
- Misses         43       44       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alicewith
Copy link

It looks good! Thank you.

@DrChainsaw DrChainsaw merged commit b63f06c into master Aug 1, 2024
5 checks passed
@DrChainsaw DrChainsaw deleted the fluxnames branch August 1, 2024 10:00
@DrChainsaw
Copy link
Owner Author

Alright, just triggered the release process so it should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I rename the input and output layers?
2 participants