Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to configure blinking of CTL tag #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tkloy24
Copy link

@tkloy24 tkloy24 commented Sep 18, 2022

This addition allows to configure the distance at which the "CTL" text starts blinking. If the configured threshold value is not reached the text will be static, otherwise it will blink to receive controller's attention.

Copy link
Owner

@DrFreas DrFreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
thank you for your contribution. However, if enabled, the CTL flag does already blink. Also, if the default distance is the same as the distance where the tag item is shown anyway, what's the point of it anyway? Or do you want to have just the CTL to blink and the requests not?
I don't want to sound harsh, but I need a bit more understanding what you want to archieve here, because this functionality is already there.

@DrFreas DrFreas added enhancement New feature or request question Further information is requested labels Sep 19, 2022
@tkloy24
Copy link
Author

tkloy24 commented Sep 19, 2022

Hi DrFreas,

sure, let me explain the idea: Currently the CTL-flag will start blinking as soon as an aircraft passes the ctldist which is 40 nm by default.

However it would be nice to have a two-step solution:

  1. An aircraft is in the area but has no landing clearance (Static red "CTL" text for information)
  2. An aircraft is pretty close to the aircraft and still has no landing clearance (Blinking "CTL" flag to show urgency)
    --> I believe that this would help to identify and prioritize landing traffic that really needs attention.

I have set the value for distanceCTLBlink to 40 nm in order to allow backward compatibility: If a user wishes to have the logic as it always was he does not need to change anything. Users who would like the two-step mode can then simply adjust the distanceCTLBlink to any value that suits them best.

@DrFreas
Copy link
Owner

DrFreas commented Sep 20, 2022

Thank you for clarifying. I already thought something like this, but wanted to make sure you really want this.
I will consider merging this, however I'm thinking about even more awareness maybe, like a flashing background behind the CTL flag to really raise big awareness. So you would have the normal behaviour as usual, but then like an "alert" that needs your immediate attention. So maybe that the CTL is written in black with a red background?

@tkloy24
Copy link
Author

tkloy24 commented Sep 20, 2022

Sounds great, I also like the idea of an even "more urgent" indication like the flashing background if Euroscope supports something like this in lists or tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants