Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonSemanticDebug: Now forwarding parent scope variables to children scopes. #267

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

DragonJoker
Copy link
Owner

It allows for RenderDoc to track those variables through scopes.

@DragonJoker DragonJoker added the enhancement New feature or request label Jul 23, 2024
@DragonJoker DragonJoker added this to the 2.9.0 milestone Jul 23, 2024
@DragonJoker DragonJoker self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (bb0b3e7) to head (9bc50ec).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #267   +/-   ##
============================================
  Coverage        83.93%   83.93%           
============================================
  Files              497      497           
  Lines            58138    58164   +26     
============================================
+ Hits             48797    48819   +22     
- Misses            9341     9345    +4     
Files Coverage Δ
source/CompilerSpirV/SpirVBlock.cpp 81.48% <100.00%> (+0.42%) ⬆️
source/CompilerSpirV/SpirVBlock.hpp 100.00% <ø> (ø)
source/CompilerSpirV/SpirVFunction.cpp 29.41% <100.00%> (+2.13%) ⬆️
source/CompilerSpirV/SpirVFunction.hpp 90.90% <ø> (ø)
source/CompilerSpirV/SpirVModule.cpp 71.37% <100.00%> (+0.26%) ⬆️
source/CompilerSpirV/SpirVModule.hpp 88.46% <ø> (ø)
source/CompilerSpirV/SpirVNonSemanticDebug.hpp 80.00% <ø> (ø)
source/CompilerSpirV/SpirVGenerateStatements.cpp 82.71% <90.00%> (-0.14%) ⬇️
source/CompilerSpirV/SpirVNonSemanticDebug.cpp 91.76% <81.25%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0b3e7...9bc50ec. Read the comment docs.

…copes.

It allows for RenderDoc to track those variables through scopes.
Copy link

@DragonJoker DragonJoker merged commit d2ef920 into development Jul 23, 2024
7 checks passed
@DragonJoker DragonJoker deleted the debug_local_vars branch July 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant