Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pifiles in wav64 and opus #606

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

nopjne
Copy link

@nopjne nopjne commented Sep 12, 2024

Allow wav64_open to work with "pi:/" based files.

Copy link
Collaborator

@rasky rasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've sent a few comments in

include/wav64.h Outdated Show resolved Hide resolved
include/wav64.h Outdated Show resolved Hide resolved
src/audio/wav64.c Outdated Show resolved Hide resolved
src/audio/wav64.c Outdated Show resolved Hide resolved
src/audio/wav64.c Outdated Show resolved Hide resolved
src/audio/wav64.c Outdated Show resolved Hide resolved
src/audio/wav64.c Outdated Show resolved Hide resolved
src/audio/wav64_opus.c Outdated Show resolved Hide resolved
src/audio/wav64_opus.c Show resolved Hide resolved
src/audio/wav64internal.h Outdated Show resolved Hide resolved
@nopjne nopjne force-pushed the pi_wav branch 2 times, most recently from 1c23e9a to ddb59db Compare September 17, 2024 20:34
include/wav64.h Outdated Show resolved Hide resolved
@nopjne nopjne force-pushed the pi_wav branch 2 times, most recently from 57b2786 to 8863061 Compare September 17, 2024 22:05
Copy link
Collaborator

@rasky rasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to give a final look after all changes are made, but I guess it's starting to look fine.

src/audio/wav64.c Outdated Show resolved Hide resolved
src/audio/wav64_opus.c Outdated Show resolved Hide resolved
src/audio/wav64_opus.c Outdated Show resolved Hide resolved
src/audio/wav64_opus.c Outdated Show resolved Hide resolved
include/wav64.h Outdated Show resolved Hide resolved
src/audio/wav64.c Outdated Show resolved Hide resolved
@nopjne nopjne requested a review from rasky September 22, 2024 14:40
@rasky rasky merged commit 2d339c7 into DragonMinded:unstable Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants