Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailing stop #769

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix trailing stop #769

wants to merge 4 commits into from
+30 −21

Conversation

Phodia
Copy link

@Phodia Phodia commented Nov 14, 2022

No description provided.

@Phodia Phodia marked this pull request as draft November 14, 2022 18:38
@Phodia Phodia changed the title Fix trailing stop [WIP] Fix trailing stop Nov 14, 2022
@Phodia Phodia changed the title [WIP] Fix trailing stop Fix trailing stop Nov 16, 2022
@Phodia Phodia marked this pull request as ready for review November 16, 2022 16:19
@GuillaumeDSM
Copy link
Member

Thanks for this PR !
Did you have a chance to test it both on simulated and real trading ?

@valouvaliavlo
Copy link
Contributor

@GuillaumeDSM
Only on simulation and backtesting.
For real trading, it's same as stop_loss

@Phodia Phodia requested a review from valouvaliavlo November 17, 2022 13:39
@Herklos
Copy link
Member

Herklos commented Nov 17, 2022

Can you add a test to ensure it's fixed please? Because it seems that we doesn't have a test for that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valouvaliavlo valouvaliavlo Awaiting requested review from valouvaliavlo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Phodia @GuillaumeDSM @valouvaliavlo @Herklos