Siqad coordinates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
marcelwa
requested changes
Nov 23, 2022
marcelwa
reviewed
Nov 23, 2022
|
Don't forget to add documentation for your functions as docstrings and also add them to |
|
Please run a complete code reformatting via |
|
clang-tidy review says "All clean, LGTM! 👍" |
marcelwa
requested changes
Nov 24, 2022
| @@ -84,6 +84,34 @@ TEST_CASE("Unsigned offset coordinates", "[coordinates]") | |||
| CHECK(os.str() == "(3,2,1)"); | |||
| } | |||
|
|
|||
| TEST_CASE("siqad coordinate conversion", "[coordinates]") | |||
| { | |||
|
|
|||
|
clang-tidy review says "All clean, LGTM! 👍" |
marcelwa
approved these changes
Nov 29, 2022
Drewniok
added a commit
that referenced
this pull request
Feb 3, 2023
…cda-tum#105) * new coordinate-converter function * function to convert siqad-coordinates * ✨ function to convert siqad-coordinates and tests added * second iteration of coordinate-converter-functions and documentation added * Delete siqad_to_cartesian.hpp * ⚗️ Defect-aware physical design experiment * ⚗️ Python script to create defective surfaces * ✨ added siqad namespace to enable negative coordinates * ✨ added tests for negative coordinates * 🐛 if-else no required in "to_siqad_coord" * 🎨 d and z-coordinate as bool * 🎨 z-coordinate type changed from bool to uint8_t : 1 * Siqad coordinates (#4) * new coordinate-converter function * function to convert siqad-coordinates * ✨ function to convert siqad-coordinates and tests added * second iteration of coordinate-converter-functions and documentation added * Delete siqad_to_cartesian.hpp * ✨ added siqad namespace to enable negative coordinates * ✨ added tests for negative coordinates * 🐛 if-else no required in "to_siqad_coord" * 🎨 d and z-coordinate as bool * 🎨 z-coordinate type changed from bool to uint8_t : 1 Co-authored-by: Drewniok <jan.drewniok.reseaqrch@gmail.com> * 🐛 added "const" for return iterator of find function * 🐛 added "const" for return iterator of find function (cda-tum#80) Co-authored-by: Drewniok <jan.drewniok.reseaqrch@gmail.com> Co-authored-by: Marcel Walter <marcel.walter@tum.de> * ✨ new constructor for sidb_surface to generate surface with aspect ratio as input * 🎨 added missing docu for SiQAD coordinates * 🎨 Adjusted code based on advancements in main * new constructor for sidb_surface.cpp added (cda-tum#84) * ✨ new constructor for sidb_surface to generate a surface from an aspect_ratio Co-authored-by: Drewniok <jan.drewniok.reseaqrch@gmail.com> Co-authored-by: Marcel Walter <marcel.walter@tum.de> * 🎨 Marcel's suggestions updated * 💚 Workaround for MSVC being petty * 💚 Prevent experiment from being built if Z3 is disabled * 💚 Workaround for MSVC being petty * new layer to store charge states of SiDBs, tests included (#6) * ✨ new layer to store SiDB charge states * ✨ new layer to store SiDB charge states, test included * ✨ new layer to store charge states of SiDBs, test included * ✨ new layer to store charge states of SiDBs, test included * 🎨 updated Marcel's suggestions * 🎨 updated Marcel's suggestions * 🎨 Marcel's suggestions updated and new traits added * 🎨 added tests for traits * 🎨 added cstdint to avoid clang-tidy conflict * 🎨 reformat code * 🎨 Marcel's suggestions updated * 🎨 Marcel's suggestions updated * 🎨 Marcel's suggestions updated * 🎨 docu completed (.rst) Co-authored-by: Drewniok <jan.drewniok.reseaqrch@gmail.com> * Fiction structure (#13) * 🎨 several changes * 🎨 lattice parameters to simulation parameters * ✨ electrostatic potential between two SiDBs, test is included * ✨ Siqad coordinates are converted to a coordinate (x,y) on the Si-substrate * ✨ Distance between two SiDBs on the substrate with given lattice parameters, test included * ✨ Distance matrix where all inter-distances are stored, test included * ✨ Potential matrix with test * ✨ distance and potential matrix * Delete simulation_init.hpp * ✨ local potential, test included * ✨ check for physical validity, tests are included * ✨ function to calculate the system's total electrostatic potential energy, tests included * ✨ function to check for physically validity (configuration and population stability) * ✨ small changes * ✨ deleted * ✨ function name "distance_sidb_pair" instead of "distance_SiDB_pair" * ✨ capital letters replaced * ✨ changed member names * 🎨 added last line * 🎨 put constants header to technology folder * 🎨 added larger distance for testing * 🎨 small changes * 🎨 convert charge configuration to a unique index * 🎨 convert charge configuration to a unique index and vise versa * 🎨 convert int charge state to label * 🎨 Marcel's suggestions updated * 🎨 small changes * 🎨 use mutable in lambda caption * 🎨 small changes * 🎨 added static_cast * 🎨 Marcel's suggestions updated * 🎨 update * 🎨 todo added * 🎨 big structure change * 🎨 deleted unordered_map include * 🎨 whole structure changed * 🎨 tests added * 🎨 implemented ExGs * 🎨 ExGs finished * 🎨 ExGs finished and single header files deleted * 🎨 new simulation approach implemented * 🎨 simulation works * 🎨 function to compute the time-to-solution * 🎨 function to compute the time-to-solution and started to implement experiment * 🎨 experiment works and result table is printed * 🎨 ExGS with vector instead of unordered_maps * 🎨 on the way to implement all with vectors * 🎨 simulation works * 🎨 "code cleaning" * 🎨 small experiments to find performance * 🎨 performance increased by using reserve and get_potential in next_N function * 🎨 hourglass gates for benchmarking * 🎨 trying to improve accuracy * 🎨 benchmark files added * 🎨 simulation works and produces DAC data * 🎨 temperature is implemented * 🎨 test updated * 🎨 small changes in different files * 🎨 functions as seperate headers and test for quicksim added * 🎨 functions as seperate headers * 🎨 most of the clang-tidy and SonarLint warnings are solved * Delete experiments/bestagon/layouts/gates directory * Delete experiments/bestagon/layouts/defect_robust directory * 🎨 most of the clang-tidy and SonarLint warnings are solved * Delete temperature.hpp * Delete speedsim.hpp * Delete occupation_function.hpp * Delete simulation_sidb.cpp * 🎨 tried to solve most of the clang-tidy and SonarLint warnings. * 🎨 tried to solve windows building error and remaining clang-tidy errors. * 🎨 MAXFLOAT corrected. * 🎨 removed static term from charge functions. * 🎨 best_energy limit changed back to double * 🎨 replaced "else if" by else in read_sqd_layout * 🎨 replaced "const auto" by std::string at file.path(), still trying to fix windows building problems * 🎨 added const to std::string * 🎨 using auto keyword * 🎨 using .string() * 🎨 comma removed in folder vector * 🎨 cell<Lyt> replaced by typename Lyt::cell for windows. * 🎨 include for <fiction_experiments.hpp> changed * 🎨 another typename added for windows * 🎨 typename cell<Lyt> changed in sidb_surface * 🎨 typename coordinate<Lyt> changed in sidb_surface * 🎨 small change * 🎨 again <Lyt> change in sidb_surface * 🎨 auto const replaced by auto const * 🎨 return EXIT_SUCCESS * 🎨 return header for exgs * 🎨 small changes, using EXPERIMENTS_PATH to read benchmark files * 🎨 small changes to update Marcel's comments * 🎨 deleted test snippet in exhaustive_ground_state_simulation.cpp * 🎨 stats pointer for tts function. * 🎨 copy assignment operator added. * 🎨 tts and exgs renamed to "time_to_solution" and "exhaustive_ground_state_simulation.hpp", respectively. * Delete exhaustive_ground_state_simulation_bestagon_gate.cpp in "cda-tum/sidb-layouts-quicksim-validation" repo * Delete quicksim_bestagon_gate.cpp in cda-tum /sidb-layouts-quicksim-validation repo * Delete tts_acc_all_bestagon.cpp in cda-tum/sidb-layouts-quicksim-validation repo * 🎨 number of repetitions changed from const int to const uint64_t --------- Co-authored-by: Drewniok <jan.drewniok.reseaqrch@gmail.com> * 🔨 new function to get all SiDB positions in nm (x,y). * 🔨 two functions which are useful for the integration into SiQAD * 🔨 main merged in groundstate_simulation_sidb * 🔥 Removed artifact files * 🎨 Applied ClangFormat * 🎨 Code formatting * 🔨 test for time-to-solution added * 🔨 test for check_groundstate.cpp added * 🔨 reformat code * 🎨 Moved files and fixed documentation * 🎨 Adjusted simulation algorithms to construct their own `charge_distribution_surface` objects * 🔨 pop_stability added to "is_groundstate.hpp" * 💚 Fixed compiler errors on template deduction * 🔨 tts_acc_tss gets cell-level-layout as input. * 🔨 tts_acc_tss gets quicksim_params as input (includes physical sidb parameters and simulation parameters). * 🚨 Addressed linter warnings regarding `std::rand()` (which are not wrong) --------- Co-authored-by: Marcel Walter <marcelwalter.mw@gmail.com> Co-authored-by: Marcel Walter <marcel.walter@tum.de> Co-authored-by: Drewniok <jan.drewniok.reseaqrch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.