Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow our exceptions #146

Open
seisatsu opened this issue Apr 30, 2017 · 3 comments
Open

Narrow our exceptions #146

seisatsu opened this issue Apr 30, 2017 · 3 comments

Comments

@seisatsu
Copy link
Member

For everywhere possible, change broad exception clauses to list the particular exceptions to be expected.

@pmer
Copy link
Member

pmer commented May 1, 2017

I've no idea how this will impact the stability of the engine... but some exceptions mean our internal state is messed up somehow and we can't recover. We can't always be perfect. I'm looking forward to seeing how we fare with this strategy.

@pmer
Copy link
Member

pmer commented May 1, 2017

Ah, looks like except Exception will allow SystemExit, KeyboardInterrupt, and GeneratorExit to pass through uncaught.

Just saw https://docs.python.org/3/library/exceptions.html#exception-hierarchy

@seisatsu
Copy link
Member Author

seisatsu commented May 1, 2017

Well that's a dealbreaker. We'll just deal with this issue later. I've moved us back to old exceptions for now.

@seisatsu seisatsu added the style label Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants