Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 [Templates] Broken due to maximum string length #5

Merged
merged 1 commit into from
Dec 10, 2016
Merged

#2 [Templates] Broken due to maximum string length #5

merged 1 commit into from
Dec 10, 2016

Conversation

tobbexiv
Copy link
Contributor

@tobbexiv tobbexiv commented Dec 9, 2016

Change the type from string to text.

@tobbexiv
Copy link
Contributor Author

tobbexiv commented Dec 9, 2016

After merge this still needs to be considered:

  • The update script has version 1.?.? as I do not know the version number where this will be shipped. This needs to be adjusted!
  • The update script also overrides the second preinstalled template which might be changed by the user. I decided to do this as the teamplate is broken and it is very unlikely that the user adjusted it.

@luisreyes
Copy link
Contributor

Thanks for taking care of this. The next bump is minor. It should be 1.0.3. I'll update and publish the package with all changes soon.

@luisreyes luisreyes merged commit 0742710 into DrivenNetwork:master Dec 10, 2016
luisreyes referenced this pull request Dec 10, 2016
@luisreyes
Merge pull request #6 from DrivenNetwork/pr/5
ce52998 
Template "HTML" Column Type Update - 1.0.3
@tobbexiv tobbexiv deleted the issue-2-broken-templates branch December 10, 2016 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobbexiv @luisreyes