✅ Some tests are failing midnight due to timezone issues.

Drogecode · Sep 29, 2024 · 5835b73 · 5835b73
1 parent 52862b0
commit 5835b73
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/...rogecode.Knrm.Oefenrooster.TestClient/Tests/Components/DrogeCode/CalendarBaseCardTests.cs b/...rogecode.Knrm.Oefenrooster.TestClient/Tests/Components/DrogeCode/CalendarBaseCardTests.cs
@@ -31,7 +31,10 @@ public void NoNameButDayTest([Frozen] IStringLocalizer<App> L)
 
         var training = new TrainingAdvance { DateStart = DateTime.UtcNow };
         var cut = RenderComponent<CalendarBaseCard>(parameter => parameter.Add(p => p.Training, training).Add(p => p.ReplaceEmptyName, true));
-        cut.Markup.Should().Contain(training.DateStart.ToLocalTime().ToString("dddd"));
+        var timeZone = "Europe/Amsterdam";
+        var zone = TimeZoneInfo.FindSystemTimeZoneById(timeZone);
+        var dateStart = TimeZoneInfo.ConvertTimeFromUtc(training.DateStart, zone);
+        cut.Markup.Should().Contain(dateStart.ToString("dddd"));
     }
 
     [Theory]
@@ -96,6 +99,7 @@ public void OnClickHistoryAndSettingsTest([Frozen] IStringLocalizer<App> L)
     }
 
     private bool Clicked = false;
+
     private void ClickButton()
     {
         Clicked = true;
@@ -106,4 +110,4 @@ private void Localize(IStringLocalizer<App> L1)
         Services.AddSingleton(L1);
         A.CallTo(() => L1["till"]).Returns(new LocalizedString("till", "till with some more text to ensure it is replaced"));
     }
-}
+}
diff --git a/tests/Drogecode.Knrm.Oefenrooster.TestServer/Tests/BaseTest.cs b/tests/Drogecode.Knrm.Oefenrooster.TestServer/Tests/BaseTest.cs
@@ -304,7 +304,7 @@ protected async Task<Guid> AddDefaultSchedule()
             TimeStart = new TimeOnly(11, 0),
             TimeEnd = new TimeOnly(14, 0),
             ValidFromDefault = DateTime.Today,
-            ValidUntilDefault = DateTime.Today.AddDays(7),
+            ValidUntilDefault = DateTime.Today.AddDays(14),
             CountToTrainingTarget = false,
             Order = 10
         };

diff --git a/...code.Knrm.Oefenrooster.TestServer/Tests/ControllerTests/DefaultScheduleControllerTests.cs b/...code.Knrm.Oefenrooster.TestServer/Tests/ControllerTests/DefaultScheduleControllerTests.cs
@@ -201,6 +201,8 @@ public async Task PutScheduleToNewGroupTest()
         Assert.NotNull(patchResult.Value?.Patched?.UserDefaultAvailableId);
 
         var allForGroup = await DefaultScheduleController.GetAllByGroupId(newGroup.Id);
+        Assert.NotNull(allForGroup.Value?.DefaultSchedules);
+        Assert.NotEmpty(allForGroup.Value.DefaultSchedules);
         allForGroup.Value!.DefaultSchedules!.FirstOrDefault(x => x.Id == DefaultDefaultSchedule)!.UserSchedules.Should().Contain(x => x.UserDefaultAvailableId == patchResult.Value!.Patched!.UserDefaultAvailableId);
 
         var idDefaultGroup = (await DefaultScheduleController.GetAllGroups()).Value!.Groups!.FirstOrDefault(x => x.IsDefault)!.Id;