Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW_NC_read_out_vars() doesn't close file connection #424

Closed
dschlaep opened this issue Jul 31, 2024 · 0 comments · Fixed by #429
Closed

SW_NC_read_out_vars() doesn't close file connection #424

dschlaep opened this issue Jul 31, 2024 · 0 comments · Fixed by #429
Assignees
@N1ckP3rsl3y
Labels
bug
Milestone
Release v8+

Comments

@dschlaep
Copy link
Member

It appears that SW_NC_read_out_vars() was missed when commit 6964cfb "Use goto to close files in read files" was applied. We should fix that
@dschlaep dschlaep added the bug label Jul 31, 2024
@dschlaep dschlaep added this to the Release v8+ milestone Jul 31, 2024
N1ckP3rsl3y added a commit that referenced this issue Aug 7, 2024
@N1ckP3rsl3y
Correctly close file on fail for nc read/write functions
e27d5d4 
- `SW_NC_write_output()` & `SW_NC_read_out_vars()`
	* New goto target to close open file
	* Use goto instead of return upon failure

- Issues #424 and #426
@N1ckP3rsl3y N1ckP3rsl3y mentioned this issue Aug 7, 2024
Merged
@N1ckP3rsl3y N1ckP3rsl3y linked a pull request Aug 7, 2024 that will close this issue
Close open files on error within SW_netCDF.c #429
Merged
N1ckP3rsl3y added a commit that referenced this issue Aug 8, 2024
@N1ckP3rsl3y
Merge pull request #429 from DrylandEcology/fix_closeOpenFilesOnFailNC
54abffe 
- In SOILWAT2 v8.0.0, there is a bug where the two functions - `SW_NC_write_output()` & `SW_NC_read_out_vars()` - upon error, the open file does not get closed

- The mentioned two functions now close files upon failure before leaving the function
- See #424 and #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N1ckP3rsl3y N1ckP3rsl3y

Labels
bug
Projects
None yet
Milestone
Release v8+
Development

Successfully merging a pull request may close this issue.

Close open files on error within SW_netCDF.c DrylandEcology/SOILWAT2
2 participants
@dschlaep @N1ckP3rsl3y