Feature soildensity #215
Merged
Feature soildensity #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- close #209 (Integrate SOILWAT2's soil density descriptor) - see DrylandEcology/SOILWAT2#324 (SOILWAT2 submodule points to this devel branch for now) - new behavior: user specifies whether input soil density represents matric or bulk density; code then determines both matric and bulk density values from inputs - Class `swSite` gains new slot `"SoilDensityInputType"` and associated methods `swSite_SoilDensityInputType()` (#209). "SoilDensityInputType" encodes if soil density inputs represent matric soil or bulk soil values.
Codecov Report
@@ Coverage Diff @@
## release/devel_v6.0.0 #215 +/- ##
========================================================
- Coverage 54.56% 54.52% -0.05%
========================================================
Files 42 42
Lines 6478 6491 +13
========================================================
+ Hits 3535 3539 +4
- Misses 2943 2952 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
N1ckP3rsl3y
approved these changes
Aug 3, 2022
…ensity type) SOILWAT2 commit ac323024c142840211c6e41d84083e7f4211ef3b (Merge pull request #324 from DrylandEcology/feature_soildensity_type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close Integrate SOILWAT2's soil density descriptor #209
new behavior: user specifies whether input soil density represents matric or bulk density; code then determines both matric and bulk density values from inputs
Class
swSitegains new slot"SoilDensityInputType"and associated methodsswSite_SoilDensityInputType()(Integrate SOILWAT2's soil density descriptor #209)."SoilDensityInputType" encodes if soil density inputs represent matric soil or bulk soil values.