Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Commit

Permalink
Added tests for new MqMessageReader Skip method.
Browse files Browse the repository at this point in the history
Added MqMessageReader.Position setter and tests.
  • Loading branch information
DJGosnell committed Sep 29, 2016
1 parent f2f737a commit 9c2cb4f
Show file tree
Hide file tree
Showing 2 changed files with 113 additions and 2 deletions.
98 changes: 98 additions & 0 deletions src/DtronixMessageQueue.Tests/Mq/MqMessageWriterReaderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,23 @@ public void MessageReader_reads_to_end_multi_frame() {
Assert.True(message_reader.IsAtEnd);
}

[Fact]
public void MessageReader_reads_to_end_multi_frame_skipping_empty_frame() {
var expected_value = new byte[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 0 };

message_builder.Write(new byte[] { 1, 2, 3, 4, 5 });
message_builder.FinalizeFrame();
message_builder.FinalizeFrame();

message_builder.Write(new byte[] { 6, 7, 8, 9, 0 });
var message = message_builder.ToMessage();
message_reader.Message = message;

Assert.Equal(expected_value, message_reader.ReadToEnd());
Assert.True(message_reader.IsAtEnd);
}


[Fact]
public void MessageReader_reads_to_end_partial() {
var expected_value = new byte[] { 4, 5, 6, 7, 8, 9, 10 };
Expand Down Expand Up @@ -521,6 +538,87 @@ public void MessageReader_throws_when_reading_simple_type_across_frames() {
Assert.Throws<InvalidOperationException>(() => message_reader.ReadInt32());
}

[Fact]
public void MessageReader_skips_bytes() {
message_builder.Write(new byte[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 });
var message = message_builder.ToMessage();
message_reader.Message = message;

message_reader.Skip(4);

Assert.Equal(4, message_reader.Position);
Assert.False(message_reader.IsAtEnd);
}

[Fact]
public void MessageReader_skips_empty_frames() {
message_builder.Write(new byte[] { 1, 2 });
message_builder.FinalizeFrame();
message_builder.FinalizeFrame();
message_builder.Write(new byte[] { 3, 4 });

var message = message_builder.ToMessage();
message_reader.Message = message;

message_reader.Skip(3);



Assert.Equal(3, message_reader.Position);
Assert.Equal(4, message_reader.ReadByte());
Assert.True(message_reader.IsAtEnd);
}

[Fact]
public void MessageReader_sets_position() {
message_builder.Write(new byte[] { 1, 2, 3, 4, 5, 6, 7, 8, 9 });
var message = message_builder.ToMessage();
message_reader.Message = message;

message_reader.Position = 2;
Assert.Equal(2, message_reader.Position);

message_reader.Position = 1;
Assert.Equal(1, message_reader.Position);

message_reader.Position = 3;
Assert.Equal(3, message_reader.Position);
}

[Fact]
public void MessageReader_sets_position_and_reads() {
message_builder.Write(new byte[] {1, 2, 3, 4, 5});
var message = message_builder.ToMessage();
message_reader.Message = message;


Assert.Equal(new byte[] {1, 2, 3, 4, 5}, message_reader.ReadBytes(5));
Assert.Equal(5, message_reader.Position);


message_reader.Position = 2;
Assert.Equal(2, message_reader.Position);

Assert.Equal(new byte[] { 3, 4, 5 }, message_reader.ReadBytes(3));
Assert.Equal(5, message_reader.Position);
Assert.True(message_reader.IsAtEnd);
}

[Fact]
public void MessageReader_sets_position_and_updates_isatend() {
message_builder.Write(new byte[] { 1, 2, 3, 4, 5, 6, 7, 8, 9 });
var message = message_builder.ToMessage();
message_reader.Message = message;

Assert.False(message_reader.IsAtEnd);

message_reader.Position = 9;
Assert.True(message_reader.IsAtEnd);

message_reader.Position = 8;
Assert.False(message_reader.IsAtEnd);
}


}
}
17 changes: 15 additions & 2 deletions src/DtronixMessageQueue/MqMessageReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,22 @@ public MqMessage Message {
}

/// <summary>
/// Byte position in the message.
/// Get or set the byte position in the message.
/// </summary>
public int Position => absolute_position;
public int Position {
get {
return absolute_position;
}
set {
current_frame = message?[0];
frame_position = 0;
message_position = 0;
absolute_position = 0;
if (value != 0) {
Skip(value);
}
}
}

/// <summary>
/// Total length of the bytes in this message.
Expand Down

0 comments on commit 9c2cb4f

Please sign in to comment.