Skip to content

Commit

Permalink
fix: fix various bugs from the latest commits including login bugs (#30)
Browse files Browse the repository at this point in the history
  • Loading branch information
Duell10111 authored Aug 27, 2024
1 parent be8ebc5 commit 396d5fd
Show file tree
Hide file tree
Showing 70 changed files with 23,649 additions and 2,028 deletions.
18 changes: 3 additions & 15 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,11 @@ runs:
using: composite
steps:
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc

- name: Cache dependencies
id: yarn-cache
uses: actions/cache@v3
with:
path: |
**/node_modules
.yarn/install-state.gz
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/package.json', '!node_modules/**') }}
restore-keys: |
${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
${{ runner.os }}-yarn-
cache: 'npm'

- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --immutable
run: npm i --legacy-peer-deps
shell: bash
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
uses: ./.github/actions/setup

- name: Lint files
run: yarn lint --quiet
run: npm run lint --quiet

- name: Typecheck files
run: yarn typecheck
run: npm run typecheck
16 changes: 7 additions & 9 deletions App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,14 @@ const App = () => {
<YoutubeContextProvider>
<AccountContextProvider>
<DownloaderContext>
<StatusBar
// TODO: Currently only dark-mode exists
barStyle={isDarkMode ? "light-content" : "light-content"}
/>
<SafeAreaProvider>
<MusicPlayerContext>
<Navigation />
</MusicPlayerContext>
<MusicPlayerContext>
<StatusBar
// TODO: Currently only dark-mode exists
barStyle={isDarkMode ? "light-content" : "light-content"}
/>
<Navigation />
<FlashMessage position={"top"} />
</SafeAreaProvider>
</MusicPlayerContext>
</DownloaderContext>
</AccountContextProvider>
</YoutubeContextProvider>
Expand Down
17 changes: 11 additions & 6 deletions app.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"icon": "./assets/images/ios_icon.png",
"bundleIdentifier": "com.duell10111.reacttube",
"supportsTablet": true,
"config": {
"usesNonExemptEncryption": false
},
"infoPlist": {
"UIBackgroundModes": [
"audio"
Expand All @@ -25,15 +28,16 @@
"isTV": true,
"showVerboseWarnings": false,
"tvosDeploymentTarget": "13.4",
"removeFlipperOnAndroid": true,
"removeFlipperOnAndroid": false,
"androidTVBanner": "./assets/images/tv/tv_banner.png",
"appleTVImages": {
"icon": "./assets/images/tv/app_store_icon.png",
"iconSmall": "./assets/images/tv/app_store_icon_400.png",
"topShelf": "./assets/images/tv/app_store_icon_topshelf.png",
"topShelf2x": "./assets/images/tv/app_store_icon_topshelf.png",
"topShelfWide": "./assets/images/tv/app_store_icon_topshelf.png",
"topShelfWide2x": "./assets/images/tv/app_store_icon_topshelf.png"
"iconSmall2x": "./assets/images/tv/app_store_icon_800.png",
"topShelf": "./assets/images/tv/app_store_icon_topshelf_1x.png",
"topShelf2x": "./assets/images/tv/app_store_icon_topshelf_2x.png",
"topShelfWide": "./assets/images/tv/app_store_icon_topshelf_wide1x.png",
"topShelfWide2x": "./assets/images/tv/app_store_icon_topshelf_wide2x.png"
}
}
],
Expand All @@ -60,6 +64,7 @@
],
"name": "reacttube",
"slug": "reacttube",
"userInterfaceStyle": "automatic"
"userInterfaceStyle": "dark",
"backgroundColor": "#000000"
}
}
Binary file added assets/images/tv/app_store_icon_800.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed assets/images/tv/app_store_icon_topshelf.png
Binary file not shown.
Binary file added assets/images/tv/app_store_icon_topshelf_1x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/tv/app_store_icon_topshelf_2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 396d5fd

Please sign in to comment.