Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] key shortcut for closing chat should change #292

Closed
2 tasks done
Dun-sin opened this issue Sep 26, 2023 · 7 comments · Fixed by #335
Closed
2 tasks done

[FEATURE] key shortcut for closing chat should change #292

Dun-sin opened this issue Sep 26, 2023 · 7 comments · Fixed by #335
Assignees
Labels

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 26, 2023

Description

The key shortcut for closing a chat is Ctrl + c which is also the copy shortcut, not a good mixture to close a chat should change to ctrl + shift + c that we don't have a mismatch.

You can find the code for this here and the hook code at useKeyPress.js

useKeyPress(['c'], () => handleClose());
useKeyPress(['n'], () => handleClose(true));

Screenshots

No response

Additional information

No response

👀 Have you checked if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

@Dun-sin Dun-sin added enhancement feature Medium It's average in difficulty up for grabs anyone can ask to work on this hacktoberfest labels Sep 26, 2023
@github-actions
Copy link
Contributor

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@RiccardoCafa
Copy link
Contributor

Hi @Dun-sin can I take this issue in charge?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 27, 2023

Hi @Dun-sin can I take this issue in charge?

Definitely, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck

@Dun-sin Dun-sin added assigned and removed up for grabs anyone can ask to work on this labels Sep 27, 2023
@RiccardoCafa
Copy link
Contributor

The shortcut CTRL + SHIFT + C currently opens the developer tools in Google Chrome, specifically activating the "Select Element" tool.
What if we opt for CTRL + SHIFT + X instead?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 29, 2023

The shortcut CTRL + SHIFT + C currently opens the developer tools in Google Chrome, specifically activating the "Select Element" tool. What if we opt for CTRL + SHIFT + X instead?

oh for sure, didn't think of that since i use firefox. ctrl+ shift + x works fine

@RiccardoCafa
Copy link
Contributor

@Dun-sin I noticed that there's a TypeScript version of the useKeyPress hook in this project. However, it appears that the project is configured to use only JavaScript. This file has some purpose?

Also I was wondering if would be nice if we implement this shortcut feature with a Builder design pattern so it's easy to build and maintain different kind of shortcuts in the future. Let me know what do you think!

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 29, 2023

@Dun-sin I noticed that there's a TypeScript version of the useKeyPress hook in this project. However, it appears that the project is configured to use only JavaScript. This file has some purpose?

Also I was wondering if would be nice if we implement this shortcut feature with a Builder design pattern so it's easy to build and maintain different kind of shortcuts in the future. Let me know what do you think!

Do a git pull,and see some magic😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants