-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] key shortcut for closing chat should change #292
Comments
It's great having you contribute to this project by creating an issueMake sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓 |
Hi @Dun-sin can I take this issue in charge? |
The shortcut CTRL + SHIFT + C currently opens the developer tools in Google Chrome, specifically activating the "Select Element" tool. |
oh for sure, didn't think of that since i use firefox. ctrl+ shift + x works fine |
@Dun-sin I noticed that there's a TypeScript version of the useKeyPress hook in this project. However, it appears that the project is configured to use only JavaScript. This file has some purpose? Also I was wondering if would be nice if we implement this shortcut feature with a Builder design pattern so it's easy to build and maintain different kind of shortcuts in the future. Let me know what do you think! |
Do a git pull,and see some magic😆 |
Description
The key shortcut for closing a chat is Ctrl + c which is also the copy shortcut, not a good mixture to close a chat should change to
ctrl + shift + c
that we don't have a mismatch.You can find the code for this here and the hook code at useKeyPress.js
Whisper/client/src/components/Anonymous.jsx
Lines 103 to 104 in a253b2d
Screenshots
No response
Additional information
No response
👀 Have you checked if this issue has been raised before?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue ?
None
The text was updated successfully, but these errors were encountered: