Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for shift key in useKeyPress hook and changed mismatched shortcut #335

Merged
merged 5 commits into from
Oct 1, 2023
Merged

feat: added support for shift key in useKeyPress hook and changed mismatched shortcut #335

merged 5 commits into from
Oct 1, 2023

Conversation

RiccardoCafa
Copy link
Contributor

Feature

Fixes #292

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Implemented a Builder design pattern for better support shortcuts
  • Changed shortcut for closing chat from "ctrl + c" to "ctrl + shift + x"

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

@vercel
Copy link

vercel bot commented Sep 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

client/src/hooks/useKeyPress.js Outdated Show resolved Hide resolved
client/src/hooks/useKeyPress.ts Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 1, 2023 7:10pm

@RiccardoCafa RiccardoCafa changed the title feat: added key press builder for shortcuts feat: added support for shift key in useKeyPress hook Oct 1, 2023
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one last thing, please add comments where necessary

@RiccardoCafa RiccardoCafa changed the title feat: added support for shift key in useKeyPress hook feat: added support for shift key in useKeyPress hook and changed mismatched shortcut Oct 1, 2023
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 5997dc1 into Dun-sin:main Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] key shortcut for closing chat should change
2 participants