Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTHER] use the logical AND operator to display the message when the user chooses to show a bad word #667

Closed
Dun-sin opened this issue Aug 18, 2024 · 2 comments · Fixed by #726
Closed

[OTHER] use the logical AND operator to display the message when the user chooses to show a bad word #667

Dun-sin opened this issue Aug 18, 2024 · 2 comments · Fixed by #726
Assignees
@Dun-sin
Labels
2 days Not more than 2 days to raise a PR assigned EddieHub:good-first-issue frontend this issue requires knowlegde of frontend good first issue Good for newcomers hacktoberfest 🏁 status: ready for dev issue is ready to be worked on

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 18, 2024 •
edited
Loading

What would you like to share?

Whisper/client/src/components/Chat.jsx

Lines 531 to 533 in dbec99c

: badwordChoices[id] === 'show'
? message
: message

change that code to:

badwordChoices[id] === 'show' && message

Additional information

This issue depends on #663
@Dun-sin Dun-sin added up for grabs anyone can ask to work on this hacktoberfest frontend this issue requires knowlegde of frontend 2 days Not more than 2 days to raise a PR 🚦 status: awaiting approval waiting for maintainer to accept issue as ready to work labels Aug 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

To reduce notifications, issues are locked until they are valid/approved and to be assigned. In the meantime read the contributing guidelines -> https://github.com/Dun-sin/Whisper/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
@wheval wheval mentioned this issue Oct 22, 2024
Closed
3 tasks
@Dun-sin Dun-sin added 🏁 status: ready for dev issue is ready to be worked on good first issue Good for newcomers EddieHub:good-first-issue and removed 🚦 status: awaiting approval waiting for maintainer to accept issue as ready to work labels Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you.

@github-actions github-actions bot unlocked this conversation Nov 22, 2024
@Dun-sin Dun-sin self-assigned this Nov 23, 2024
@github-actions github-actions bot added assigned and removed up for grabs anyone can ask to work on this labels Nov 23, 2024
@Dun-sin Dun-sin mentioned this issue Nov 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dun-sin Dun-sin

Labels
2 days Not more than 2 days to raise a PR assigned EddieHub:good-first-issue frontend this issue requires knowlegde of frontend good first issue Good for newcomers hacktoberfest 🏁 status: ready for dev issue is ready to be worked on
Projects
None yet
Milestone
No milestone
1 participant
@Dun-sin