-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move the message list to its own component #715
refactor: Move the message list to its own component #715
Conversation
@wheval is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like alot of things can be moved to their respective new components and don't need to be props, find those things and move them accordingly.
Also you weren't assigned to these issues therefore you shouldn't work on them, revert to the previous code for this two:
Fixed https://github.com/Dun-sin/Whisper/issues/666 Fixed https://github.com/Dun-sin/Whisper/issues/667
@wheval also screenshots should be of the working code, i.e website being up and runing with the area where your change was done as a screen recording if it's not a basic UI change |
hi @wheval the time assigned to this Issue is over, your PR is now closed. Thanks for trying to contribute, you're free to ask to work on other issues, if you can meet up with the time assigned. |
Fixes Issue
My PR closes #663
π¨βπ» Changes proposed(What did you do ?)
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots