Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move the message list to its own component #715

Closed

Conversation

wheval
Copy link
Contributor

@wheval wheval commented Oct 22, 2024

Fixes Issue

My PR closes #663

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  1. Fixed change the span to a button for the is bads words element #666
  2. Fixed use the logical AND operator to display the message when the user tries to show a bad word #667
  3. Created a component for BadWordsMessage
  4. Created a component for MessagesList

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

move
move1
move2
move3
move4

Copy link

vercel bot commented Oct 22, 2024

@wheval is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@wheval wheval changed the title Move the message list to its own component #663 refactor: Move the message list to its own component Oct 22, 2024
Copy link
Owner

@Dun-sin Dun-sin Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like alot of things can be moved to their respective new components and don't need to be props, find those things and move them accordingly.

Also you weren't assigned to these issues therefore you shouldn't work on them, revert to the previous code for this two:
Fixed https://github.com/Dun-sin/Whisper/issues/666 Fixed https://github.com/Dun-sin/Whisper/issues/667

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 24, 2024

@wheval also screenshots should be of the working code, i.e website being up and runing with the area where your change was done as a screen recording if it's not a basic UI change

@Dun-sin Dun-sin added the 7 days Not more than 7 days(1week) to raise a PR label Oct 24, 2024
@Dun-sin
Copy link
Owner

Dun-sin commented Nov 1, 2024

hi @wheval the time assigned to this Issue is over, your PR is now closed. Thanks for trying to contribute, you're free to ask to work on other issues, if you can meet up with the time assigned.

@Dun-sin Dun-sin closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7 days Not more than 7 days(1week) to raise a PR
Projects
None yet
2 participants