Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modified notification nature when the tab is active #368

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

Virtual4087
Copy link
Contributor

@Virtual4087 Virtual4087 commented Oct 3, 2023

Fixes #366

My PR closes #issue_number_here

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Modified js so that notification don't work while the tab is active

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

@vercel
Copy link

vercel bot commented Oct 3, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 3, 2023

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass. Most often, our PR titles are something like one of these:

* docs: correct typo in README

* feat: implement dark mode"

* fix: correct remove button behavior

Linting Errors

* Found type "Feat", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"

@Virtual4087 Please fix this error, if you don't know how, try this:

  • Read the error carefully or read the contributing file
  • Checkout past merged Pull requests to see how they were done for it to be merged

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged

@Virtual4087 Virtual4087 changed the title Feat: Modified notification nature when the tab is active feat: Modified notification nature when the tab is active Oct 3, 2023
@Virtual4087
Copy link
Contributor Author

My bad I'm new to this I didn't realize I had to resolve the convo I thought only you had the authorityπŸ˜‚

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 3, 2023

My bad I'm new to this I didn't realize I had to resolve the convo I thought only you had the authorityπŸ˜‚

i'm not taking about the convo

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 3, 2023

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

i'm talking about this, error isn't gone

@Virtual4087
Copy link
Contributor Author

My bad changed "Fixes issues #366" to "Fixes #366"

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 3, 2023 4:46pm

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 24e0dbb into Dun-sin:main Oct 3, 2023
2 checks passed
@Virtual4087
Copy link
Contributor Author

FinallyπŸ˜…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Notification shouldn't work while the tab is active
2 participants